search

dustymabe / summit-2017-container-lab

8 stars 36 forks source link

match ch. 2 FROM image to other labs #48

Closed tchughesiv closed 7 years ago

dustymabe commented 7 years ago

pretty sure we were trying to do this on purpose to make a point. 

>>> No tags on image specification - updates could break things

although registry.access.redhat.com/rhel7 isn't really a "tag"

tchughesiv commented 7 years ago

hmm, ya... a tag in the context of "best practice" would probably be something like: registry.access.redhat.com/rhel7:7.3-74

Using registry.access.redhat.com/rhel in ch. 2 but not in the others doesn't make sense, imo... BUT, if we wanted to use it in chapter 2, we'll likely need to make a point to cache registry.access.redhat.com/rhel ... even if its just a pointer to registry.access.redhat.com/rhel7

dustymabe commented 7 years ago

hmm, ya... a tag in the context of "best practice" would probably be something like: registry.access.redhat.com/rhel7:7.3-74

agreed. if that is the current latest version I can add that to the list of images to pre-cache

Using registry.access.redhat.com/rhel in ch. 2 but not in the others doesn't make sense, imo... BUT, if we wanted to use it in chapter 2, we'll likely need to make a point to cache registry.access.redhat.com/rhel ... even if its just a pointer to registry.access.redhat.com/rhel7

I already pre-cache rhel, but like I said if we want to use "real tags rather than fake ones, i'm ok with that.

tchughesiv commented 7 years ago

ok... my vote would be, at the very least, to use "FROM registry.access.redhat.com/rhel7" in all chapters for consistency. For ch. 3, if we wanted, we could add the 7.3-74 tag as well to demonstrate a good practice.

Thoughts?

dustymabe commented 7 years ago

my thoughts are that we use rhel7 up until the point where we explain that tagging is better and then we use registry.access.redhat.com/rhel7:7.3-74 at every point after that.