HTTP_AUTH_USER / HTTP_AUTH_PASS ignored

dutchcoders / transfer.sh

Easy and fast file sharing from the command-line.

https://github.com/dutchcoders/transfer.sh

MIT License

15.09k stars 1.54k forks source link

HTTP_AUTH_USER / HTTP_AUTH_PASS ignored #563

Closed odoucet closed 1 year ago

odoucet commented 1 year ago

Hello, It appears HTTP_AUTH_USER and HTTP_AUTH_PASS are not doing anything (when used as docker container). I was expecting an authentication to be required on file uploads when these two variables are present, but nothing happens and everyone can upload a file without auth. I'm wondering if I'm using it correctly ...

aspacca commented 1 year ago

@odoucet can you please share how do you launch your docker container? either cli command line for docker run, your docker-compose file, or whatever? :)

aspacca commented 1 year ago

woha! there was a huge bug in the basic auth logic since #537 !

glad you reported @odoucet

fixed in #564

odoucet commented 1 year ago

Thanks! I'll wait for https://hub.docker.com/r/dutchcoders/transfer.sh to be updated and I'll confirm to you if it is fixed :)