search

dutchiexl / BehatHtmlFormatterPlugin

This is a behat plugin to generate HTML reports
MIT License
112 stars 116 forks source link

Fix undefined variable strScePending in Behat2Renderer. #100

Closed fengtan closed 5 years ago

fengtan commented 6 years ago

Hi,

I get this small notice when formatting results with this plugin: PHP Notice: Undefined variable: strScePending in /root/.composer/vendor/emuse/behat-html-formatter/src/Renderer/Behat2Renderer.php on line 119

Here is a proposed solution -- looks like we just need to define strScePending.

rdotter commented 5 years ago

Pr can be closed, changes already merged in master. Update your upstream to see the changes :-) @fengtan

fengtan commented 5 years ago

Confirmed -- PR was merged on Oct 30, 2018 in 675eb3d

https://github.com/dutchiexl/BehatHtmlFormatterPlugin/blob/master/src/Renderer/Behat2Renderer.php#L71-L75