search

dutchiexl / BehatHtmlFormatterPlugin

This is a behat plugin to generate HTML reports
MIT License
112 stars 117 forks source link

Screenshot is not attached when testing outline scenarios. #121

Open ceniy opened 3 years ago

ceniy commented 3 years ago
  1. When outline scenarios are executed, the ScenarioTested::BEFORE and ScenarioTested::AFTER are not triggered. So I added ExampleTested::BEFORE and ExampleTested::AFTER in the event list.
  2. Removed the codes in onAfterOutlineTested as the count will be added inside onAfterScenarioTested
PurHur commented 3 years ago

Looks good for me but we should wait some time.

PurHur commented 3 years ago

I checked the constants. Looks good but i cant test it now. Do you think this will break anything? If not i will merge it.

ceniy commented 3 years ago

I tested in my local with outline scenarios and normal scenarios. They work fine. The count of the passed and failed scenarios are correct. Furthermore screenshots are attached in the correct place.

PurHur commented 3 years ago

Then thank you for your contribution. Everything helps :)

PurHur commented 3 years ago

Hmm i will look into it. But i have to setup my pipeline again. If anybody is intrested in something automated go for it.

kalkin commented 3 years ago

So what is the state of this PR?

PurHur commented 2 years ago

@kalkin I think this PR will break stuff. Are you interested in working on the project? We actually need a github action pipeline to test this package itself. Quiet an interesting project.

PurHur commented 9 months ago

@kalkin is this PR still important to you?

I will be more active in the next time and i will check your PR as well again if it breaks stuff or not else i will merge all the things to the current master