search

dutchigor / vue-grapesjs-composables

MIT License
17 stars 4 forks source link

Included GrapesJS version #6

Open dutchigor opened 2 years ago

dutchigor commented 2 years ago

Is there a reason why grapes-min.js is bundled into the vue-grapesjs-composables package? I would like to be able to use the latest grapesjs modules.

dutchigor commented 2 years ago

This is because the reactive layer that this package provides accesses a lot of the functionality provided by GrapesJS, some of it going quite deep. As such, a different version has a reasonable chance of breaking this package.

If you wish to update the version, I would be happy with a pull request including the updated version. Please then use the example project to test that it still works. If there is no rush, I will update this myself as well when I have some more time but I can not give a timeline on this.

dutchigor commented 2 years ago

From @rodenp: I totally understand that bundling grapesjs with your plugin ensures that it works independent of the installed grapesjs. However is there another way that makes it possible to pass down the 'main' grapesjs to your plugin and if so use that version and if not use the bundled version? Alternatively a simpler solution would be to use the 'main' grapesjs and simply state in your documentation what version of grapesjs you plugin is known to work with.

dutchigor commented 2 years ago

@rodenp, This is a good point. I'm actually not sure this package needs to be bundled at all since that should be handled by Vue in the final project and npm should handle the compatibility. I'll test this without a bundler and remove it if it's not needed.

stevenhurth commented 1 year ago

This project is exactly what I was looking for. Awesome work!

I am indeed interested in this particular ticket. Mainly, the functionality added in grapesjs 0.19 added the Page Manager, and some nifty Storage Manager functionality. These would be hugely beneficial in a project I'm working on, but having the old version bundled creates some issues.

Is there any progress on this request so far?

padcom commented 1 year ago

This project is exactly what I was looking for. Awesome work!

@stevenhurth Looks like you're not the only one. Before I found this package I was doing exactly the same thing as this package does. Can we at least suggest an upgrade to 0.21.1 since 0.18 is ages old.

While we're at it, is there a ticket about typescripting the hell out of this package?