search

dutu / poloLender

Free, open source, high performance bot for lending funds on Poloniex exchange
https://github.com/dutu/poloLender
Other
160 stars 47 forks source link

config.json is not ignored nor tracked #104

Closed ibjeong closed 7 years ago

ibjeong commented 7 years ago

The new version saves the configuration to config.json, which is not .gitignore'd nor tracked.

It's not causing any problem but better to be ignored i think as .env* were.

dutu commented 7 years ago

@kukyakya, yes git is not tracking config.json and this is by purpose. Firstly, it ensures that your own config.json is not overwritten when you update the application code next time you update your application (hence your configuration settings will be kept) Secondly, it ensures your own config.json is not uploaded to github if you use a fork of the application.

Unless you add the config.json manually to git (which you shouldn't do), it doesn't necessarily need to be added to .gitignore (but it doesn't hurt if it is - so I can add it when I upgrade the app version).

dutu commented 7 years ago

config.json added to .gitignore starting with version 1.1.0