search

dutu / poloLender

Free, open source, high performance bot for lending funds on Poloniex exchange
https://github.com/dutu/poloLender
Other
160 stars 47 forks source link

Prettify Notifications #96

Closed hemant6488 closed 7 years ago

hemant6488 commented 7 years ago

Hi Dutu, please review the changes, and tell me if they're fine.

Thanks

dutu commented 7 years ago

@hemant6488 thanks for the PR. I see you've modified the message format both for telegram and console logger. Have you tested the changes and see how the console log looks when running locally and when running on Heroku. It's likely that the introduction of new lines will give a wired look due to coloring and the timestamps. Will be glad to receive your feedback on this.

hemant6488 commented 7 years ago

@dutu You're welcome, thanks for the bot. Here are the screenshots of the console preview and telegram preview, doesn't look too shabby to me. Also, I don't have a running Dyno, so couldn't test it out on Heroku.

screen shot 2017-07-04 at 1 38 00 am photo6258169668904789942

dutu commented 7 years ago

@hemant6488 new lines does not work when displayed on heroku. Also the new version of the code will display the timestamp for each log line, which will also make the pretty notification not to be as expected.

I suggest the message to telegram logger to be formatted differently from the message to console.