duxbuse / ninthage-data-analytics

A better way for the project to ingest tournament results
GNU General Public License v3.0
1 stars 0 forks source link

Vermin Swarm has Vampire Data in it #116

Closed modmoto closed 2 years ago

modmoto commented 2 years ago

If you open up the Internal Balance for Vermin Swarm, there are some entries from Vampires aswell. I guess a few games have wrong data?

image

SanderND commented 2 years ago

Root cause is an list recorded as Vermin but who are Vampire count. Two consequences:

1) wrong units reported: i fix that by re-uploading this tourney 2) we dont monitor this to actively correct this. this could be done by adding armyname to the static unit data. When ARMYNAME from the results table doesnt equal ARMYNAME from static unit data, we know something is wrong as I just join on the unitname.

SanderND commented 2 years ago

After uploading the tourney this is corrected. Also a validation step will be added to prevent wrong uploads. Correctively i will check all records with the same issue and re-upload these tourneys.