duxbuse / ninthage-data-analytics

A better way for the project to ingest tournament results
GNU General Public License v3.0
1 stars 0 forks source link

Units that exist in multiple categories correctly allocated #144

Closed SanderND closed 1 year ago

SanderND commented 2 years ago

The static data has the OrgName of a unit. e.g. A unit of Marksmen is Core for Dwarven Holds. However, in some armies a unit exists in more than one category. As a result Tableau cannot choose which OrgName belongs to the unit. This creates issues for the Internal Balance tab, as some units do not get allocated.

Ideally, the parses decided itself which OrgName belongs to it and stores this data.

SanderND commented 2 years ago

Solved in Tableau by linking both armyname and unitname. This resolved entries like 'warriors' which exist in multiple armies.

Sometimes mounts (e.g. skysloop) exist in multiple categories too. But as character mounts are in our field unit upgrade we can assume all mounts that are entered as unit are thus to be categorized to the other unit category. E.g. naval ordnance in case of the skysloop. unitnames that are not home in any of the other categories are bad entries and get army category = null and are catched by the quality monitoring.

duxbuse commented 2 years ago

Is this resolved then?

SanderND commented 2 years ago

No this is not solved. My Tableau solution only fixed mounts which were chose as monster entry (e.g. Gargantula). However, a unit like warhounds (WDG) can be core or special. My Tableau solution didnt fix that. Issue #147 is about the same thing so can be merged i think.

SanderND commented 1 year ago

Solved with new query for interface to Tableau.