more than one valid psf can be selected for a given frame - Githubissues

duxfrederic / lightcurver

A pipeline for precise extraction of light curves and deconvolution of a region from multiple wide-field astronomical images

https://duxfrederic.github.io/lightcurver/

GNU General Public License v3.0

8 stars 1 forks source link

more than one valid psf can be selected for a given frame #15

Closed duxfrederic closed 6 months ago

duxfrederic commented 7 months ago

I thought I had fixed this, but

run the pipeline all the way to the completion of PSF estimation
set redo_psf to true
change the stars the PSF is allowed to use
redo the PSF

Now the photometry selects two PSFs per frame, duplicating the frame. (-> two fluxes per frame)

Possibilities for fixing this:

Enforce only one PSF per footprint hash per frame?
Create new key for the PSF? (containing info on which stars are allowed to be used)
just modify the deconvolution/photometry preparation query to select only one PSF? Which one then? Lowest chi-squared? Makes things hard to debug for user.

duxfrederic commented 6 months ago

went for lowest chi2 route. this is an edge case anyway