duyminh1998 / pycmo

Command Modern Operations Learning Environment
Other
50 stars 23 forks source link

Refactor pycmo to handle both premium and Steam editions of Command #12

Closed duyminh1998 closed 10 months ago

duyminh1998 commented 11 months ago

We should

refactor pycmo to handle both Premium and Steam editions of Command

Because

currently pycmo are written to be only compatible with the premium edition of Command, which requires an expensive license to which many users do not have access

Complexity

Medium to hard. We can proceed in two phases of work. First, we can refactor the current codebase and note pieces of code that are exclusive to the premium edition of the game. We can then add the codebase to support the Steam edition of the game.

Definition of Done

Users are able to specify and use pycmo for both the premium and Steam editions of Command. More emphasis will be placed on the latter because we do not have access to the premium version of the game (and this codebase has already been developed previously).

XiaoFanTong commented 10 months ago

Amazing! But who can I contact to purchase Command PE.

XiaoFanTong commented 10 months ago

BTW, where is CPE.ini

duyminh1998 commented 10 months ago

It has been a while so I do not remember. Check for a Config folder. This could be in your Command installation folder in Program Files or ProgramData. Note that CPE.ini is only present in the Premium edition of the game.

XiaoFanTong commented 10 months ago

It has been a while so I do not remember. Check for a Config folder. This could be in your Command installation folder in Program Files or ProgramData. Note that CPE.ini is only present in the Premium edition of the game.

I do not find CPE.ini in the Steam editions of Command, so how can I handle Steam editions of Command with pycmo?

duyminh1998 commented 10 months ago

It has been a while so I do not remember. Check for a Config folder. This could be in your Command installation folder in Program Files or ProgramData. Note that CPE.ini is only present in the Premium edition of the game.

I do not find CPE.ini in the Steam editions of Command, so how can I handle Steam editions of Command with pycmo?

Getting pycmo to work with the Steam version is ongoing work and the purpose for this issue. You can check out a demo by following these instructions.

XiaoFanTong commented 10 months ago

It has been a while so I do not remember. Check for a Config folder. This could be in your Command installation folder in Program Files or ProgramData. Note that CPE.ini is only present in the Premium edition of the game.

I do not find CPE.ini in the Steam editions of Command, so how can I handle Steam editions of Command with pycmo?

Getting pycmo to work with the Steam version is ongoing work and the purpose for this issue. You can check out a demo by following these instructions.

The demo runs successfully. Good job!

duyminh1998 commented 10 months ago

Places to refactor:

duyminh1998 commented 10 months ago

Currently blocked by this issue in an attempt to focus the work

duyminh1998 commented 10 months ago

Closed by this MR