search

duynguyen24501 / pe

0 stars 0 forks source link

Long description cannot display in full even maximizing the screen #3

Open duynguyen24501 opened 3 years ago

duynguyen24501 commented 3 years ago

Long description ends with ellipsis and cannot display in full. This makes the user cannot differentiate between two long descriptions.

Screenshot 2020-11-13 at 4.23.23 PM.png

nus-se-bot commented 3 years ago

Team's Response

This is an intended behaviour as we did not intend entry's description/tag to be super long. As a business owner, a description of an expense or revenue does not necessarily need to be very long. (no need for proper sentence structure etc) Likewise for tags as well. Additionally, the Tag class and Ui aspect regarding Tag remained unchanged from AB-3. So its display and functionality is inherited from AB-3

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: AB3 does not have description field. The argument that team gave "As a business owner, a description of an expense or revenue does not necessarily need to be very long. (no need for proper sentence structure etc)" is very ambiguous to me. I am not sure whether we can put such an assumption on the users, but I think as long as team did not restrict the number of characters/words for description, the users are allowed to write as much as they want.

Additionally, the UI changed from full width (as AB3) to shorter width, so only 10 words or even fewer would get truncated. Thus, the behaviour is totally different from AB3, so I believe team cannot take AB3 inheritance as defense argument. Therefore, I will reject team response.