search

duytq94 / flutter-intro-slider

Simple and configurable app introduction slider for Flutter
https://pub.dartlang.org/packages/intro_slider
MIT License
677 stars 141 forks source link

Remove forced maxLines on Description #1

Closed robisaks closed 6 years ago

robisaks commented 6 years ago

The description should be left to be whatever length the developer needs. I can't think of any case where a developer would want the text of the description to be cut off. If it should have less text, then they can reduce the word count.

duytq94 commented 6 years ago

Hi @robisaks , thank for your feedback. You're right, but should we give the user option to set value for better? If they're not set, we'll use the default as you did.

robisaks commented 6 years ago

I thought about making it configurable, but it really doesn't make sense to have max lines on an intro screen, since you always want it to show all the text.

duytq94 commented 6 years ago

OK, please help me add more configurable when you have free time, thanks.

LiveRock commented 3 years ago

I set maxLineTextDescription: 10 but I can only see 5 lines. Why?