search

duytq94 / flutter-intro-slider

Simple and configurable app introduction slider for Flutter
https://pub.dartlang.org/packages/intro_slider
MIT License
677 stars 141 forks source link

Button Colors not showing in 2.4.0 #106

Closed vincentliu98 closed 3 years ago

vincentliu98 commented 3 years ago

I upgraded the package from 2.3.3 to 2.4.0 after upgrading my Flutter project to Flutter 2. However, the colors of buttons in the bottom disappeared, despite I specified colors as below:

      colorSkipBtn: darkGreen,
      colorDoneBtn: darkGreen,

Screenshot_1619126821

I think the cause is using TextButton's primary parameter instead of backgroundColor. After modifying the package on my end and testing it out, I was able to restore the button colors.

Screenshot_1619126969

Also, in 2.4.0, highlightColorSkipBtn and highlightColorDoneBtn are not used in TextButton. Can they be added to reproduce the effect from 2.3.3?

Thanks.

duytq94 commented 3 years ago

Thanks for your report 💯 Fixed immediately here https://github.com/duytq94/flutter-intro-slider/releases/tag/2.4.1