dvajs / dva

🌱 React and redux based, lightweight and elm-style framework. (Inspired by elm and choo)
https://dvajs.com/
MIT License
16.24k stars 3.17k forks source link

chore: update dva-immer peerDependencies to avoid conflict. #2443

Closed yaohaizh closed 3 years ago

yaohaizh commented 3 years ago
Checklist
Description of change

There is a conflict of dva version when using umi & umi/plugin-dva from the latest version:

npm WARN ERESOLVE overriding peer dependency npm WARN Found: dva@2.6.0-beta.22 npm WARN node_modules/@umijs/plugin-dva/node_modules/dva npm WARN dva@"^2.6.0-beta.20" from @umijs/plugin-dva@0.12.1 npm WARN node_modules/@umijs/plugin-dva npm WARN @umijs/plugin-dva@"0.12.1" from @umijs/preset-react@1.8.7 npm WARN node_modules/@umijs/preset-react npm WARN npm WARN Could not resolve dependency: npm WARN peer dva@"^2.5.0-0" from dva-immer@0.5.2 npm WARN node_modules/@umijs/plugin-dva/node_modules/dva-immer npm WARN dva-immer@"^0.5.2" from @umijs/plugin-dva@0.12.1 npm WARN node_modules/@umijs/plugin-dva

codecov-commenter commented 3 years ago

Codecov Report

Merging #2443 (e3d6b85) into master (3eaee30) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2443   +/-   ##
=======================================
  Coverage   85.90%   85.90%           
=======================================
  Files          18       18           
  Lines         518      518           
  Branches      114      114           
=======================================
  Hits          445      445           
  Misses         59       59           
  Partials       14       14           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3eaee30...e3d6b85. Read the comment docs.

yaohaizh commented 3 years ago

@sorrycc please help review whether this change is suitable. Thanks.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.