search

dvalters / HAIL-CAESAR

The High-Performance Architecture-Independent LISFLOOD-CAESAR model of floodplain, river, and sediment dynamics
http://dvalters.github.io/HAIL-CAESAR
GNU General Public License v3.0
38 stars 12 forks source link

Test for flipped catchment left-right #26

Closed dvalters closed 6 years ago

dvalters commented 6 years ago

Tests for 'symmetry' regression i.e. does a change to code make any difference whether the model input domain terrain is flipped from left to right. So in this case, the river flows East-West. The flipped test case simply flips the data so that it now runs West-East. A typical breaking change to the model should break both tests, if only one is broken, something more subtle may be wrong...

For reference: these are the DEMs (outlet on the West - original, outlet on the East - flipped) Units are 'grid cells' at 50m resolution

normal_dem_boscastle flipped_dem_boscastle

dvalters commented 6 years ago

Possibly need to set OMP_NUM_THREADS in the travis yml and run_tests script to replicate results exactly between local machine and travis server, but otherwise OK to merge now