dvalters / HAIL-CAESAR

The High-Performance Architecture-Independent LISFLOOD-CAESAR model of floodplain, river, and sediment dynamics
http://dvalters.github.io/HAIL-CAESAR
GNU General Public License v3.0
38 stars 12 forks source link

Bug in reach_x and reach_y coordinates #53

Open dvalters opened 1 year ago

dvalters commented 1 year ago

There is a bug in the reach mode on master and the reach mode tag. The parameters for setting the reach input points reach_x and reach_y are the wrong way round to the way most people think of them (sorry in my head I'm used to swapping them round for i, j notation in matrices....)

Most people have spotted this I think and just "flipped" the coordinates round (hopefully it produces obviously wrong/odd output if you don't...)

I'll add a fix soon but in the meantime you can just switch your x and y coords around if using reach mode.