search

dvalters / fuse-netcdf

ESoWC project to develop a Python utility to mount NetCDF files as a file-system in user space. (FUSE)
Other
8 stars 3 forks source link

Only support mounting a single NetCDF file #12

Closed blazk closed 6 years ago

blazk commented 6 years ago

Hello Declan, Current version seems to support mounting a directory containing multiple netcdf files. Would you consider simplifying the code by only supporting mounting a single NetCDF file? The logic is a bit difficult to follow as the code needs to deal with both NetCDF files and regular files/directories, and this feature (mounting directories) doesn't seem to work correctly anyway.

I personally would remove these bits & keep it simple: if first argument is a netcdf file mount it, otherwise abort.

What do you think?

dvalters commented 6 years ago

Hi Blazej,

Yes I agree that would be much simpler - I have some more changes I'm working on today, I will incorporate this as well.

Declan

dvalters commented 6 years ago

Closed by PR #18