dvanaken / ZealousZamboni

0 stars 1 forks source link

Logger Bug #26

Closed ghost closed 10 years ago

ghost commented 10 years ago

There is occurence where ZzLog.logLevelStart is called once, but ZzLog.logLevelEnd is called twice. This is similar to malloc and free, how 2 free calls are invalid...

Investigating and fixing

ghost commented 10 years ago

Fixed

kcorman commented 10 years ago

lol you're still awake? I love the sound effects and levels by the way

On Fri, May 16, 2014 at 9:00 AM, Tuan Vo notifications@github.com wrote:

Closed #26 https://github.com/danava04/ZealousZamboni/issues/26.

— Reply to this email directly or view it on GitHubhttps://github.com/danava04/ZealousZamboni/issues/26#event-121950871 .

ghost commented 10 years ago

thx! i was gonna make more levels, but there were a bunch of blockers. gotta figure out how to make this single skater levels compatible with the progress bar, cuz even if skater dies, based on progress bar, player still wins....

kcorman commented 10 years ago

Hey I noticed that too, I'm working on it. It's a fairly easy fix, will push it soon.

On Fri, May 16, 2014 at 9:20 AM, Tuan Vo notifications@github.com wrote:

thx! i was gonna make more levels, but there were a bunch of blockers. gotta figure out how to make this single skater levels compatible with the progress bar, cuz even if skater dies, based on progress bar, player still wins....

— Reply to this email directly or view it on GitHubhttps://github.com/danava04/ZealousZamboni/issues/26#issuecomment-43350735 .

kcorman commented 10 years ago

Okay I fixed it. It at least works in your level 3-- I haven't thoroughly tested it. Now I'm going to scramble to get my levels up to pair. I really like where you have been going with this.

On Fri, May 16, 2014 at 9:23 AM, Kenny Corman kennywcorman@gmail.comwrote:

Hey I noticed that too, I'm working on it. It's a fairly easy fix, will push it soon.

On Fri, May 16, 2014 at 9:20 AM, Tuan Vo notifications@github.com wrote:

thx! i was gonna make more levels, but there were a bunch of blockers. gotta figure out how to make this single skater levels compatible with the progress bar, cuz even if skater dies, based on progress bar, player still wins....

— Reply to this email directly or view it on GitHubhttps://github.com/danava04/ZealousZamboni/issues/26#issuecomment-43350735 .

ghost commented 10 years ago

yes, it was in my level 3 that that bug came up. because both skaters died exactly at the same time, by design of that level. i think that level might serve as a good "unit test", for skaters dieing at same time scenario

dvanaken commented 10 years ago

Did you guys push this bug fix yet? I just experienced it in the first of Tuan's zombie levels.

On Fri, May 16, 2014 at 9:46 AM, Tuan Vo notifications@github.com wrote:

yes, it was in my level 3 that that bug came up. because both skaters died exactly at the same time, by design of that level. i think that level might serve as a good "unit test", for skaters dieing at same time scenario

— Reply to this email directly or view it on GitHubhttps://github.com/danava04/ZealousZamboni/issues/26#issuecomment-43353333 .

kcorman commented 10 years ago

Wait Tuan made zombie levels? I only saw his levels one two and three

On Fri, May 16, 2014 at 10:38 AM, danava04 notifications@github.com wrote:

Did you guys push this bug fix yet? I just experienced it in the first of Tuan's zombie levels.

On Fri, May 16, 2014 at 9:46 AM, Tuan Vo notifications@github.com wrote:

yes, it was in my level 3 that that bug came up. because both skaters died exactly at the same time, by design of that level. i think that level might serve as a good "unit test", for skaters dieing at same time scenario

— Reply to this email directly or view it on GitHub< https://github.com/danava04/ZealousZamboni/issues/26#issuecomment-43353333>

.

— Reply to this email directly or view it on GitHubhttps://github.com/danava04/ZealousZamboni/issues/26#issuecomment-43358735 .

ghost commented 10 years ago

I did not make any zombie levels.

kcorman commented 10 years ago

Yeah it turns out she just meant the existing old zombie level

On Fri, May 16, 2014 at 11:47 AM, Tuan Vo notifications@github.com wrote:

I did not make any zombie levels.

— Reply to this email directly or view it on GitHubhttps://github.com/danava04/ZealousZamboni/issues/26#issuecomment-43366138 .