dvanderbeek / leather

Bootstrap tools - UI Kit, Devise Views, and Component Partials
MIT License
22 stars 14 forks source link

Make sure Templates folder gets installed during Gem install #11

Closed onlydole closed 9 years ago

onlydole commented 9 years ago

Is there any reason why this folder does not get copied currently? I can submit a pull request if this is a desired feature!

dvanderbeek commented 9 years ago

Can you clarify when you are picturing this getting copied over? In the current version, it should copy all the files in the templates folder into your host app when you run rails g leather:install - is that not working properly for you?

onlydole commented 9 years ago

That is correct!

I Believe the issue is due to the gemspec

s.files = Dir["{app,config,db,lib}/**/*", "MIT-LICENSE", "Rakefile", "README.rdoc"]

should be

s.files = Dir["{app,config,db,lib,templates}/**/*", "MIT-LICENSE", "Rakefile", "README.rdoc"]

As when I install this (have tried a few times), the only folders that get moved over are app, config, lib, and test.

I saw an older issue where someone just copied in the folder manually and that does work for me as well once I do that.

dvanderbeek commented 9 years ago

Gotcha - yeah, feel free to submit a PR if you've verified that the change fixes the issue. Thanks! Hopefully this is helpful in your app!

dvanderbeek commented 9 years ago

Actually, just to clarify, are you saying you've actually copied the app/config/lib/test directories into your host app? Those should not get copied when you run the install generator, only the files in templates. Everything else should just get served directly from the gem.

onlydole commented 9 years ago

I have submitted a pull request to alleviate that issue! I was copying the templates directory as that was not getting copied over or getting served directly from the gem (that PR fixes that problem for me though).

12

onlydole commented 9 years ago

Thank you @dvanderbeek!