dvankley / firefly-plaid-connector-2

Connector to pull Plaid financial data into the Firefly finance tool
GNU General Public License v3.0
94 stars 14 forks source link

Container hostname conflict with Firefly hostname #88

Closed Kvan7 closed 3 months ago

Kvan7 commented 3 months ago

In the docker files, the default hostname is the same as the container's name. This causes issues when this docker container is on the same network as the main Firefly iii docker containers as firefly_iii_core has the hostname of app. In the end this results in the firefly_iii_cron docker container not calling the correct container.

The fix for this is to just add:

    hostname: plaidconnector

to the docker containers, or literally anything else as the hostname. I tested this and it worked perfectly for me. Realistically there is no reason for the connector to be on the same network as firefly but i just have it setup like that and ran into this issue so just making this for documentation. I ran into this as i have all my docker containers on the same network to be able to just have my reverse proxy use their hostnames instead of ip addresses.

I'll make a PR for this real quick since it's like a 2 line fix, but could also be like a commented out line with a not to uncomment if on same network or something i guess.