search

dvankley / firefly-plaid-connector-2

Connector to pull Plaid financial data into the Firefly finance tool
GNU General Public License v3.0
94 stars 14 forks source link

feat: Add configuration allowItemToFail to poll mode, and add a gate… #92

Closed dkichler closed 2 months ago

dkichler commented 3 months ago

… around each access_token/item update to allow it to fail without failing the entire poll sync

Maintains backward compatibility with existing behaviour with default of false.

Addressed #91

dvankley commented 3 months ago

I'm still trying to get my oauth setup with Plaid sorted out so I can fix my personal build and have something to regression test on; will take a look at this (and the rest of the backlog of issues) once that's done.

dkichler commented 3 months ago

Did a round of regression testing on this myself only to realize how naive I was wrt to coroutines (this was my first encounter with them, havin spend almost no time in Kotlin). Fixed it up and verified it works as intended in my local instance.

dkichler commented 2 months ago

Ok, all feedback addressed and the patch is nice and slim 😎

dvankley commented 2 months ago

Looks good. Thanks for bearing with me on the feedback cycle. I'll merge it and cut a new release when I get a chance.

dkichler commented 2 months ago

No problem, it was good feedback!