search

dvankley / firefly-plaid-connector-2

Connector to pull Plaid financial data into the Firefly finance tool
GNU General Public License v3.0
94 stars 14 forks source link

Upgrade gradle-wrapper to v8.8 #95

Closed nprzy closed 2 months ago

nprzy commented 2 months ago

This PR upgrades Gradle from v7.5 to v8.8. This is required to use newer versions of Kotlin and to build with newer JDK. https://docs.gradle.org/current/userguide/compatibility.html

Commit was generated by following the instructions at https://docs.gradle.org/current/userguide/upgrading_version_7.html. I did not make any changes except for what Gradle auto-generated for us.

nprzy commented 2 months ago

Side note, should gradle/wrapper/gradle-wrapper.jar be committed here at all? In the wake of the xz hack I think we should all be a little more skeptical of binaries directly commited to git repos. I biased for leaving it due to my unfamiliarity with github, but I'm happy to amend and drop it if everything will still works without it.

dvankley commented 2 months ago

Side note, should gradle/wrapper/gradle-wrapper.jar be committed here at all?

I'm not very experienced with gradle (this is the only project I've used it in), but it seems that is indeed the design intent of gradle. Here's a lively discussion on the topic: https://stackoverflow.com/questions/20348451/why-should-the-gradle-wrapper-be-committed-to-vcs.

In the wake of the xz hack I think we should all be a little more skeptical of binaries directly commited to git repos.

Yeah, agreed. For now I think I'll leave it as-is, but if enough people think I should remove the gradle binaries from source control I would not be opposed to that.