search

dvargas92495 / roamjs-scripts

MIT License
2 stars 4 forks source link

Add --host option to dev command (Closes #1) #2

Closed jdevera closed 3 years ago

jdevera commented 3 years ago

When running the dev command on a Docker container, the default host value of 127.0.0.1 that gets passed to the Webpack Dev Server will allow connections only from within the container. In order to connect from the docker host, the Webpack Dev Server needs to take 0.0.0.0 as the host parameter.

This changeset introduces a new optional argument to the dev command, --host that will take the address that will be passed as a host to Webpack Dev Server. By default this 127.0.0.1.

Relates to #1

jdevera commented 3 years ago

I could not find the source of the docs at https://developer.roamjs.com/ to update them. Are they on a public repo?

jdevera commented 3 years ago

Oh, that was fast, I marked it as draft and repushed because I got the wrong email in the commit 🤦

jdevera commented 3 years ago

@dvargas92495 are releases automated?

dvargas92495 commented 3 years ago

automated on version changes to package json, which I just pushed! 0.11.0 should be live