dvasdekis / ib-gateway-docker-gcp

Leaner and Faster Interactive Brokers Docker Trading Gateway
MIT License
68 stars 19 forks source link

v981 Update #24

Closed d3an closed 3 years ago

d3an commented 3 years ago
dvasdekis commented 3 years ago

Just noticed you knocked out the v981.3d binary from the repo.

I know it isn't perfrect, but I think I added it via Github large files support last time - mind if I readd it?

dvasdekis commented 3 years ago

I also note that there's a few different timezones used, like Toronto plus also an African timezone in ib/jts.ini?

I should probably set the whole thing to UTC for the most repeatability. Does that suit you?

Thanks so much btw! This is great :)

d3an commented 3 years ago

Just noticed you knocked out the v981.3d binary from the repo.

I know it isn't perfrect, but I think I added it via Github large files support last time - mind if I readd it?

I tried to do it with LFS, but its not supported when dealing with public forks. Basically had to deal with this. It could probably work for you though.

d3an commented 3 years ago

I also note that there's a few different timezones used, like Toronto plus also an African timezone in ib/jts.ini?

I should probably set the whole thing to UTC for the most repeatability. Does that suit you?

Thanks so much btw! This is great :)

Yeah, set it all to UTC. Not really sure why the African timezone kept getting repopulated, but still, standardized time zones is a good bet.

dnna commented 3 years ago

Nice to see this update! 🙌🎉 Would it be possible to also create a new tag on docker hub with this version?

d3an commented 3 years ago

Nice to see this update! 🙌🎉 Would it be possible to also create a new tag on docker hub with this version?

Sure thing! Hopefully it'll also make the build status badge go green ✅