search

dvcol / synology-download

Synology Download Station browser extension built with React.
https://dvcol.github.io/synology-download/
MIT License
57 stars 6 forks source link

[feature]: Clicking the Folders of the Default Location should Navigate you to the Location #225

Closed jwmann closed 5 months ago

jwmann commented 7 months ago

Affected part

General UI, General Options/Settings, Quick menus (dropdown click), Local Downloads

Description

Right now, you have the option to set a Default Location, and this works great. If you don't select a location it'll download to the default setting: e.g. (/Volume1/MyDirectory/MyDefaultLocation)

However, if you select a new Location. Clicking the Directory from the listed default location, should bring you to that location. Right now it does nothing.

Screenshots or Mock up

https://github.com/dvcol/synology-download/assets/436270/314b95c7-83aa-47b5-bc69-edebcd0b0d10

Code example

No response

dvcol commented 7 months ago

Yes, the current tree traversal is very rudimental (I got lazy on reworking leaf/branch navigation).

Resolving nested path from top or sibling requires a significant rework of the whole state system in the file explorer, It would be nice, but I don't know when I would have the time to look into it.

If someone is interested in working on it, the relevant code is here, but it's a bit of a spaghetti code.

IMO it should be fully re-written and use virtual scrolling like mentioned in this issue

dvcol commented 5 months ago

It should be somewhat implemented in the next release.

Might be a bit buggy still if the connection is slow, so YMMV

jwmann commented 5 months ago

It should be somewhat implemented in the next release.

Might be a bit buggy still if the connection is slow, so YMMV

It works great! Thank you so much 🙌