search

dvcrn / markright

➡ Electron powered markdown editor with live preview
GNU General Public License v3.0
914 stars 55 forks source link

Rendering issue and scrollbar #21

Closed nazrhyn closed 8 years ago

nazrhyn commented 8 years ago
This is for the Windows 64-bit installer version at 0.33.6.

image

Rendering Issue

The following Markdown...

1. A list
2. More list

* First level
  * Second level

...which renders as the following, on GitHub...

  1. A list
  2. More list
    • First level
    • Second level

...is rendering as in the screenshot, above, in MarkRight.

Scrollbar

There's a funny floating scrollbar showing in the screenshot, above.

Markdown

I've put the text of my Markdown test document into a gist, here: https://gist.github.com/nazrhyn/40683f37ff3298f95ebd

dvcrn commented 8 years ago

List bug ref - https://github.com/chjj/marked/issues/530.

nazrhyn commented 8 years ago

Ah, thank you for finding that issue.

I can make a separate issue for the scrollbar thing, if you'd like? I probably shouldn't've combined them; I know better.

dvcrn commented 8 years ago

Looks like the scrollbar thing is caused by the max-width property here https://github.com/dvcrn/markright/blob/master/node/ui/css/main.css#L40

There was a reason why I put that in in the first place but I just can't remember why. I'll take it out.

For the list bug, it seems like marked is kind of inactive. We should think about switching to a alternative - https://github.com/dvcrn/markright/issues/24