dvcrn / markright

➡ Electron powered markdown editor with live preview
GNU General Public License v3.0
914 stars 55 forks source link

Task list checkboxes aren't rendered #23

Closed theia-ajax closed 8 years ago

theia-ajax commented 8 years ago

GFM supports task lists using the syntax:

- [ ] a
- [x] b
- [x] c

which gets rendered as pretty checkboxes:

Currently markright does not seem to support this. Not sure if it's planned to be supported or not because it's obviously a little more in depth than the typical markdown rendering (should clicking checkboxes in the render view update the file contents?) but I figured I should open an issue just to document whether or not that's the case.

dvcrn commented 8 years ago

Markright currently uses marked for gfm markdown rendering. There is a PR open for this feature but it is not merged back in yet https://github.com/chjj/marked/pull/587

We might need to go with a fork for the time being or find a different (better?) markdown renderer

There is a clojure implementation that could be expanded to support checkboxes. On the first look it seems to support most of the GFM features - https://github.com/yogthos/markdown-clj

dvcrn commented 8 years ago

screen shot 2015-11-11 at 2 39 31 pm

GeorgeHahn commented 8 years ago

:heart_eyes:

theia-ajax commented 8 years ago

Glorious :+1: