search

dvcrn / markright

➡ Electron powered markdown editor with live preview
GNU General Public License v3.0
914 stars 55 forks source link

Implement default spell-check functionality #48

Closed sam3d closed 8 years ago

sam3d commented 8 years ago

Using the codemirror-spell-checker package I've been able to get default spell check functionality implemented. As of yet there is no way to toggle the functionality (as I do not know clojurescript well enough to get the UI elements to modify js objects).

This should close #43.

sam3d commented 8 years ago

Hold on a sec just gonna rebase and squash this to match the master.

dvcrn commented 8 years ago

Cool, thank you! I'm going to release a new version with the changes hopefully on weekend!

StephenOTT commented 7 years ago

@dvcrn is this feature enabled by default? using 0.1.11 but seems to not work.

sam3d commented 7 years ago

I haven't used markright in a fair while, but it's not actively maintained anymore. It should be enabled by default but if it isn't working there a many number of things that could be the cause.

StephenOTT commented 7 years ago

okay np. ya not working then. :)

dvcrn commented 7 years ago

Apologies about the maintaining part. I currently just can't find the time for it but hopefully in the near future again. If any of you want to help developing it please ping me!

StephenOTT commented 7 years ago

ya no problem :)

sam3d commented 7 years ago

Man don't worry about it, I've deprecated like four projects in the last week alone as I just haven't had the time to update/fix them.

When I have more time on my hands (in a few weeks) I'm gonna take a proper look through it and perform upgrades to the new electron and other bits and pieces, but right now I'm swamped.