Open rxqd opened 8 years ago
:+1: for this from my side.
Initially I've proposed PR with SPC f e
category for consistency with spacemacs. But we decided to move atom specific keybindings to SPC _
category as meta.
More info #8
@geksilla so it will no be implemented and I need to change keys locally in my config? But why we need SPC f e d and SPC _ d duplication? if we need it would be better to extract to function
As I mentioned I'm ok too merge them. Lets wait for response from other folks.
Also feel free to join slack group channel #proton.
The f
category is one thing I don't like about spacemacs. The main reason why this duplication was introduced in the first place was to make life for spacemacs users easier that give proton a try.
Proton and atom related (=meta) commands have nothing to do with every day editor use and should in my opinion not go into file so _
, a key far away from what the user would usually use seems like perfect place. There is no chance to accidentally hit it and a special key like that categories these "special" commands quite well.
Why would for example 'reload the editor' be in file
? It just doesn't seem logical to me.
If we were to remove one, my vote would be on keeping _
and getting rid of the stuff in f
.
@dvcrn "Why would for example 'reload the editor' be in file?"
Because, I have changed my .proton file and I need to apply it. So, .proton is a file, I look a file section and "oh man!" it is there. I think, we should set options "meta_key": true
for those who wants :smile: It will be flexible
I tilt the direction of using SPC _
for reloading the editor and using SPC f
for either purely file related functions (e.g. SPC f =
for beautifying a file) or for some other purpose.
f
is a pretty valuable key given its position on the keyboard and I hardly use it once I have my dot file and packages setup the way I like them.
For example, it could be [f] -> +focus
. Then SPC f j
could be focus on pane below. Right now, those:
keys are eating up a lot of SPC
home view so they are on my mind :sweat_smile:
@DanTheColoradan In that case I agree
The 'move pane' keys will get moved into w
. I just didn't come around to do that yet.
Focus pane is available through VIM bindings (ctrl wh/j/k/l) or proton bindings (spc h/j/k/l), so what you described with f j is already possible through spc j. Navigation is one of the most important functionality. I'm standing strong behind leaving it behind as little keystrokes as possible. It's a substantial difference to hit spc f j instead of spc j. Imagine for example your workflow is centered around having a lot of panes open.
As for the core discussion, I agree with @DanTheColoradan that once your proton file is set up, you close to never have to open or interact with it anyway so putting it away inside a meta category still sounds like the best way to me.
Any other opinions from other people maybe?
BTW: One feature that I hope we can implement in the not too distant future is to rebind entire key clusters. E.g. move everything that is on spc f to spc F. Having this kind of functionality would allow you to move everything under spc _ to spc f e. Though that's still a distant idea.
Reload Atom should be in the +quit
submenu, along with a Quit option, which we don't have yet.
My suggestions, mirroring it with Spacemacs:
Key Binding | Description |
---|---|
SPC f e | +editor (or +editor config ) |
SPC f e d | Open proton dotfile |
SPC f e s | Open Atom stylesheet |
SPC f e i | Open Atom init script |
SPC f e p | Open Atom snippets |
SPC f e R | Reload proton-mode package |
SPC f e D | Toggle dev tools |
SPC q | +quit |
SPC q r | Reload Atom |
SPC q q | Quit Atom |
Guys, why we need SPC _ bindings? I use Spacemacs and I reload packages with SPC f e R
Now we have: SPC f e d | open proton dotfile SPC f e s | open atom stylesheet SPC f e i | open atom init script SPC f e p | open atom snippets
SPC d | Find proton dotfile SPC R | Reload atom SPC c | Toggle dev tools SPC r | Reload proton-mode package
I suggest to merge: SPC f e d | open proton dotfile SPC f e s | open atom stylesheet SPC f e i | open atom init script SPC f e p | open atom snippets SPC f e R | Reload atom SPC f e c | Toggle dev tools SPC f e r | Reload proton-mode package