dvcrn / proton

space-atom. spacemacs and sublimious style editing in atom
GNU General Public License v3.0
565 stars 55 forks source link

fix(core): which-key panel not appearing in Atom 1.13.0 #252

Closed geksilla closed 7 years ago

geksilla commented 7 years ago

which-key not appearing because of changes related to event target passed to command dispatcher. In this particular case event target was input.class-hidden instead of atom-text-editor.vim-mode-plus. Changes related to removing shadow dom from atom.

@dvcrn, @richarddewit can you please test this changes?

dvcrn commented 7 years ago

I just arrived at home and wanted to take a look and you already fixed it? Damn, that was fast. I'll take a look!

dvcrn commented 7 years ago

Looks like I merged this too fast. I am still having issues with which-key on 1.13 😢