search

dvcrn / proton

space-atom. spacemacs and sublimious style editing in atom
GNU General Public License v3.0
565 stars 55 forks source link

feat(core): Skip welcome unless package changes #254

Closed jackcasey closed 7 years ago

jackcasey commented 7 years ago

[Updated PR description describing latest version of the behaviour]

Added a configuration option to skip showing the welcoming dialog box if there are no packages to add or remove.

By default the welcome screen is still always shown, to enable the new behaviour set proton.core.alwaysShowWelcomeScreen to false.

jackcasey commented 7 years ago

Happy to reverse the default behaviour on this to be more consistent with Spacemacs and less jarring for existing users.

dvcrn commented 7 years ago

Code looks fine to me. However, because the current behavior is to always show it, I wonder if it might be better to set the default to true.

Also maybe we can directly add this into the MANUAL under a new configuring proton point or something like that (if you can come up with something creative 😛)

jackcasey commented 7 years ago

Will do! Cheers.

jackcasey commented 7 years ago

@dvcrn FYI I updated this as discussed. See the MANUAL on my branch.

dvcrn commented 7 years ago

Thanks a lot 😄 I'll try to get this out to APM in the next days

dvcrn commented 7 years ago

Released in 0.14.1!