fix(tools/linter) changed commands and packages according latest linter

dvcrn / proton

space-atom. spacemacs and sublimious style editing in atom

GNU General Public License v3.0

565 stars 55 forks source link

fix(tools/linter) changed commands and packages according latest linter #262

Closed geksilla closed 7 years ago

geksilla commented 7 years ago

Linter v2 has following dependencies linter-ui-default, intentsions and busy-signal which will be removed since they are not included in tools/linter layer.
Updated keybinding actions

jackcasey commented 7 years ago

As per comment on my disingenuous dupe PR #263 (closed);

Thoughts on using linter-default-ui:next and linter-default-ui:previous instead to catch all kinds of linter messages not just 'error'? I could be wrong but think this was the previous behaviour.

geksilla commented 7 years ago

Nice catch. Will update PR. Thanks @jackcasey

jackcasey commented 7 years ago

Actually one more change. It seems the default setting that is set in src/cljs/proton/layers/tools/linter/core.cljs:31 is a 'legacy' setting and is making the linter v2 welcome splash screen never go away:

See:

(defmethod get-initial-config :tools/linter []
  [["linter.statusIconScope" "File"]])

This should probably just be removed.

dvcrn commented 7 years ago

Is this good for merge?

geksilla commented 7 years ago

@dvcrn, yes. I'm using these changes for my daily work and it works as well.

dvcrn commented 7 years ago

Great 😄 I'm going to add some other fixes in, then release hopefully today