search

dvcrn / proton

space-atom. spacemacs and sublimious style editing in atom
GNU General Public License v3.0
565 stars 55 forks source link

Can't see default theme logs #281

Open clayrisser opened 7 years ago

clayrisser commented 7 years ago

The logs for the default theme do not appear. It's just a big empty box.

untitled

dvcrn commented 7 years ago

Hah, looks like a update to the theme or Atom broke it. Thanks for reporting

arguser commented 7 years ago

Hello, I have recently installed proton-mode on my work laptop (Ubuntu 17.04, Atom 1.12.2) and my home desktop (Manjaro, KDE Plasma, Atom 1.19.2). This same issue is visible on my home PC while in my work laptop is working as expected.

If you could point me to any extra information or log I could provide I'll be happy to help.

Regards

clayrisser commented 7 years ago

If this theme has bugs in it, maybe a different one should be used for the default theme.

smldis commented 7 years ago

happens to me too. Any workaround?

clayrisser commented 7 years ago

The solution is to change the default theme to one that isn't buggy. I created a pull request for it.

https://github.com/dvcrn/proton/pull/283

dvcrn commented 7 years ago

Hmm I wonder if we could just tweak the CSS instead of ripping out the theme. Let me review that PR

clayrisser commented 7 years ago

The bug is in the theme's code, not our code.

dvcrn commented 7 years ago

Can someone please give https://github.com/dvcrn/proton/pull/284 a try? If everything is fine I'll release it

arguser commented 7 years ago

@dvcrn tried #284 it generates a .proton file which sets the theme back to nucleus, thus it doesn't solve the issue.

dvcrn commented 7 years ago

@arguser thanks for trying!

Are you sure about that? The change here changes the .proton template to use atom-material as the default theme

arguser commented 7 years ago

@dvcrn Whoops, missed that one. Going to try it at home.

I didn't figure out which editor to stick to yet, found proton recently and seems to be what I'd like to use if I stick with Atom, so thank you!

Sadly I've seen you switched to another editor, still with neovim? (kinda offtopic)

geksilla commented 7 years ago

btw if you like nucleus-theme you can try flexible-ui. It still well adaptive and I didn't found any issues with it for a long time.

arguser commented 7 years ago

@dvcrn done testing, it works!