search

dvdhrm / kmscon

Linux KMS/DRM based virtual Console Emulator
http://www.freedesktop.org/wiki/Software/kmscon
Other
433 stars 81 forks source link

Autotools support #1

Closed bluetech closed 12 years ago

bluetech commented 12 years ago

Hi, I stumbled upon your project while looking for info about kms, dri, etc. You are only beginning, so I thought it might be nice to jump in and help with what I can. I even registered to github for it :)

This includes the autotools support you asked for; I am by no means a build-system expert, but this ought to work well enough.

dvdhrm commented 12 years ago

Thanks for the patches. They look good, I've added some inline-comments. I can fix them when applying the patches if you want.

Please consider that the whole project is dedicated to the Public Domain as I haven't thought about any license, yet. This may change, though.

I will merge the patches during the next days. Thank you. Regards David

bluetech commented 12 years ago

Hi, thanks for looking at this. It'd be easier if you make the fix as you see fit. (btw, what's the proper way to make minor changes to pull requests? Send a new one, add a new commit, rebase? As I said, I'm new here :)

dvdhrm commented 12 years ago

I cherry-picked your changes and fixed them on my own. Thanks for the patches.

If you have further patches, I'd prefer one pull-request for each pile of patches. And then rebase the commits if you modified them and update the pull request so if I pull I get the fixed patches not some weird fix-up commits on top of the merge.

And also group the patches logically. I don't mind if this results in one pull-requests for each change as long as each change fixes/modifies different problems.

Again, thanks and pulled ;) David

bluetech commented 12 years ago

Oh, for some reason I hadn't realized that those further commits will show up in the pull request (though it does make sense). I did not intend to push them to you yet, as you saw, but oh well.