search

dvdhrm / kmscon

Linux KMS/DRM based virtual Console Emulator
http://www.freedesktop.org/wiki/Software/kmscon
Other
433 stars 81 forks source link

Add input device feature detection, and ring them bells #14

Closed bluetech closed 12 years ago

bluetech commented 12 years ago

Hi, I cleaned up some patches I had lying around. Instead of relying on udev, we query evdev directly which is pretty nice overall. I think it's an improvement, not sure.

The excuse for doing that is adding bell (\a) support. I don't know anyone who actually has that on, but it's expected. Of course we can't use KDMKTONE ioctl because that is part of CONFIG_VT, so we need to use evdev and kmscon_input. However, I wasn't sure how to get from the vte to the input object, so I kept it out for now. I originally used callbacks from the vte to the terminal, which is also useful for other things (on the top of my head, implementing scroll lock, switching terminals/VTs, answering status report queries), what do you think?

Ran

dvdhrm commented 12 years ago

I don't understand why we want udev as optional dependency but the patches look fine. I will merge them, thanks!