search

dvdhrm / kmscon

Linux KMS/DRM based virtual Console Emulator
http://www.freedesktop.org/wiki/Software/kmscon
Other
433 stars 81 forks source link

Change KMSCON_FONT_DEFAULT_PPI to 96? #30

Closed bluetech closed 11 years ago

bluetech commented 11 years ago

Hi David, first let me say that I don't know what I'm talking about :)

Currently the default font size is 15. It was changed from 10, which appeared on the screen extremely small and illegible. Now in most applications I use (e.g. X, firefox, openoffice...) 10-11 is the "normal" size and 15 is pretty large. Changing the KMSCON_FONT_DEFAULT_PPI to 96 makes the font sizes appear like what I would expect from other applications.

I don't really understand exactly what effect that has. I read the code comments and you probably chose the 72 value for a reason. Just thought I'd ask if that's the intended behavior.

Thanks! Ran

dvdhrm commented 11 years ago

Heh, I actually don't remember why I choose 72 over 96 either (maybe because this means 1px == 1point... I don't know...). Anyway, I know most X11 apps use 96 hard-coded and I wanted to avoid any hard-coded values but instead retrieve the DPI from the monitor. But that is probably not gonna happen in the near future so I will try to add a --font-dpi option now. I will set the default to 96 as that seems to be what most people want (you're not the first asking me about it ;)).

Thanks! David

towolf commented 11 years ago

FYI: http://mjg59.dreamwidth.org/8705.html

i.e. the two links mentioned in the first sentence

dvdhrm commented 11 years ago

I have pushed 7867c50025d516afd05cde8f1ee16d2833d7c2d3 which introduces --font-dpi. The default value is 96 now. The next commit decreases the default font-size to 12 again so this should meet all expectations.

Please note that you can set all command-line options in /etc/kmscon.conf, either.

@towolf I know Matthew's article, however, I have never read the mailing-list comments. But reading them now they basically tell me that trying to receive DPI values from monitors is not recommended (or at least nothing I can rely on). So leaving it as we have it now (forced 96 DPI) seems to be the best solution? Maybe I will optionally add a monitor detection for users who want this (and primarily so I can learn more about the libdrm-Property API :P)

Thanks for all your feedback! David