search

dvdhrm / kmscon

Linux KMS/DRM based virtual Console Emulator
http://www.freedesktop.org/wiki/Software/kmscon
Other
433 stars 81 forks source link

Remove the last warning from gcc 4.6.1 #44

Closed winspool closed 11 years ago

winspool commented 11 years ago

With the patch, kmscon compile now without warnings.

Signed-off-by: Detlef Riekenberg wine.dev@web.de

dvdhrm commented 11 years ago

gcc-4.7.1 doesn't warn about this and I really dislike this patch. get_glyph() should always set "glyph" if it returns 0/success. Moreover, your fix does hide bugs inside of get_glyph() if we do not correctly set the return values.

If you want to silence this warning, then please find the root of it. The only idea I have is that gcc doesn't correctly handle shl_hashtable_find() and hence produces this warning.

Thanks! David