search

dvdhrm / kmscon

Linux KMS/DRM based virtual Console Emulator
http://www.freedesktop.org/wiki/Software/kmscon
Other
436 stars 81 forks source link

Question about mod-unifont executable-stack #81

Closed etam closed 11 years ago

etam commented 11 years ago

Rpmlint gave me the following warning: kmscon-mod-unifont.x86_64: W: executable-stack /usr/lib64/kmscon/mod-unifont.so The binary declares the stack as executable. Executable stack is usually an error as it is only needed if the code contains GCC trampolines or similar constructs which uses code on the stack. One common source for needlessly executable stack cases are object files built from assembler files which don't define a proper .note.GNU-stack section.

Is it something serious or false-positive?

dvdhrm commented 11 years ago

It's nothing major, but we really should avoid executable stacks. The problem was that I linked binary data directly with "ld" but didn't specify that the stack doesn't need to be executable.

I fixed this in 87e1cf03f264cf53d2dd65d9ae17242785484d87 Thanks!