search

dvdl16 / csf_za

South Africa Customizations - Country Specific Functionality for South Africa
MIT License
1 stars 1 forks source link

[BUG] Handle edge case of negatives in Journal Entries #3

Closed dvdl16 closed 4 months ago

dvdl16 commented 4 months ago

Current Behavior

The app calculation fails for Journal Entries with negative values in Accounting Entries

Steps To Reproduce

  1. Create a Journal Entry (or reverse entry) with negatives in the child table
  2. Create a new Value-added Return and pull in the Journal Entry
  3. See Error

Expected Behavior

Calculation should be able to handle negatives

Anything else?

See ACC-JV-2024-01457

Environment and Versions

South Africa Customisations: v0.1.0
ERPNext: v15.17.1
Frappe Framework: v15.17.3
Frappe HR: v15.14.0

Operating System

Windows

What browsers are you seeing the problem on?

Firefox