search

dvdzkwsk / react-redux-starter-kit

Get started with React, Redux, and React-Router.
MIT License
10.29k stars 2.2k forks source link

Use prop-types npm module #1218

Closed matthopson closed 7 years ago

matthopson commented 7 years ago

Addresses API changes in latest React API, where `PropTypes is deprecated. https://github.com/facebook/react/blob/master/CHANGELOG.md#1550-april-7-2017

and fixes: https://github.com/davezuko/react-redux-starter-kit/issues/1216

matthopson commented 7 years ago

Can you confirm there was a hiccup in the build - or am I missing something?

dvdzkwsk commented 7 years ago

Yeap, it was just a node-sass binary issue. Looks good to me, thank you for jumping on it.

codecov-io commented 7 years ago

Codecov Report

Merging #1218 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1218   +/-   ##
=======================================
  Coverage   72.72%   72.72%           
=======================================
  Files          12       12           
  Lines          66       66           
=======================================
  Hits           48       48           
  Misses         18       18
Impacted Files Coverage Δ
src/routes/Counter/components/Counter.js 100% <ø> (ø) :arrow_up:
src/containers/AppContainer.js 0% <ø> (ø) :arrow_up:
src/layouts/CoreLayout/CoreLayout.js 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 01b3508...af27739. Read the comment docs.