dvdzkwsk / react-redux-starter-kit

Get started with React, Redux, and React-Router.

MIT License

10.29k stars 2.2k forks source link

Refactor boilerplate jest #1265

Closed leimonio closed 6 years ago

leimonio commented 7 years ago

Having replaced Karma with mocha - chai - sinon testing utilities with Jest, this PR includes:

Jest configuration
Refactoring tests to Jest
Addition of snapshot test examples
Jest coverage & reports
Updated npm dependencies
Updated npm scripts
Removal of previous configuration using Karma with mocha - chai - sinon

leimonio commented 7 years ago

I'm also linking the relative issue https://github.com/davezuko/react-redux-starter-kit/issues/1224

codecov-io commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c1c4e8c). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1265   +/-   ##
=========================================
  Coverage          ?   77.19%           
=========================================
  Files             ?        8           
  Lines             ?       57           
  Branches          ?        7           
=========================================
  Hits              ?       44           
  Misses            ?       11           
  Partials          ?        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c1c4e8c...42a1da0. Read the comment docs.

leimonio commented 7 years ago

@davezuko It seems like codecov fails when comparing with base branch because coverage report has been changed probably. Do you think there is any way to resolve this?

feedingaliencat commented 7 years ago

Tests are broken because of the following error: SyntaxError: Unexpected token import

@kwnccc please consider the PR, that fixes the issue https://github.com/kwnccc/react-redux-starter-kit/pull/1