Closed bman654 closed 8 years ago
Is this from a completely fresh, up-to-date clone of master? I ask not because I doubt, but just to make sure.
Yes with a fresh install of the latest nose 5.
Brandon
On Feb 9, 2016, at 6:33 PM, David Zukowski notifications@github.com wrote:
Is this from a completely fresh, up-to-date clone of master? I ask not because I doubt, but just to make sure.
— Reply to this email directly or view it on GitHub.
I did add a gitattributes file that forces Linux line endings. I'll try a fresh clone without that to see if it makes a difference.
Brandon
On Feb 9, 2016, at 6:33 PM, David Zukowski notifications@github.com wrote:
Is this from a completely fresh, up-to-date clone of master? I ask not because I doubt, but just to make sure.
— Reply to this email directly or view it on GitHub.
Ok I just repro'd in a fresh directory with absolutely no changes.
D:\Documents\t>node -v
v5.6.0
D:\Documents\t>npm -v
3.6.0
D:\Documents\t>git clone git@github.com:davezuko/react-redux-starter-kit.git
Cloning into 'react-redux-starter-kit'...
remote: Counting objects: 3729, done.
remote: Compressing objects: 100% (52/52), done.
rRemote: Total 3729 (delta 17), reused 0 (delta 0), pack-reused 3675
Receiving objects: 100% (3729/3729), 632.93 KiB | 543.00 KiB/s, done.
Resolving deltas: 100% (1858/1858), done.
Checking connectivity... done.
D:\Documents\t>cd react-redux-starter-kit
D:\Documents\t\react-redux-starter-kit>npm install
D:\Documents\t\react-redux-starter-kit>npm start
> react-redux-starter-kit@1.0.0 start D:\Documents\t\react-redux-starter-kit
> better-npm-run start
running better-npm-run in D:\Documents\t\react-redux-starter-kit
Executing script: start
to be executed: babel-node bin/server
app:config Create configuration. +0ms
app:config Apply environment overrides for NODE_ENV "development". +2ms
app:webpack:config Create configuration. +1s
app:webpack:config Enable plugins for live development (HMR, NoErrors). +2ms
app:server:webpack-dev Enable webpack dev middleware. +417ms
app:server:webpack-hmr Enable Webpack Hot Module Replacement (HMR). +24ms
app:bin:server Server is now running at localhost:3000. +6ms
webpack built html-webpack-plugin for "index.html" undefined in undefinedms
Hash: c22f0ff963cdf6ded724
Version: webpack 1.12.9
Time: 4900ms
Asset Size Chunks Chunk Names
app.c22f0ff963cdf6ded724.js 477 kB 0 [emitted] app
vendor.c22f0ff963cdf6ded724.js 891 kB 1 [emitted] vendor
app.c22f0ff963cdf6ded724.js.map 590 kB 0 [emitted] app
vendor.c22f0ff963cdf6ded724.js.map 1.06 MB 1 [emitted] vendor
favicon.ico 24.8 kB [emitted]
index.html 527 bytes [emitted]
Child html-webpack-plugin for "index.html":
Asset Size Chunks Chunk Names
index.html 444 kB 0
webpack: bundle is now VALID.
Attempting to do npm run test
(or npm test
) produces the errors I quoted above.
Argh, well that's annoying. I'll try to reproduce tomorrow and if I can't I'll dust off the old Windows laptop and give it a shot there. Sinon is our special friend.
I'm gonna go out on a limb and blame it on 3dd4d043dbce767e2697a341f3a9fc44a8622447.
I'll rollback to just before that commit and give it a go.
You'll definitely be good before that commit as we were not importing sinon directly before then. Still would love to figure out why you're experiencing that error, wish I could get Travis to build for Windows as well.
yeah it works if I go to just before that commit (though the app itself doesn't due to an error in the browser JS console):
PhantomJS 2.1.1 (Windows 8 0.0.0): Executed 26 of 26 SUCCESS (0.983 secs / 0.862 secs)
TOTAL: 26 SUCCESS
=============================== Coverage summary ===============================
Statements : 87.29% ( 206/236 ), 11 ignored
Branches : 75% ( 54/72 ), 5 ignored
Functions : 81.58% ( 31/38 ), 6 ignored
Lines : 56.14% ( 32/57 )
===============================================================================
D:\Documents\t\react-redux-starter-kit>git log -1
commit a15841c32dc6abadf155ab2cfccfa13c28d76428
Author: David Zukowski <zukoweb@gmail.com>
Date: Wed Feb 3 17:31:57 2016 -0500
chore(config): remove vendor entry for redux-actions
I wonder if this line fails on windows due to path separators?
test: /sinon\/pkg\/sinon\.js/,
:+1: I bet you're exactly right.
yeah I changed it to test: /sinon\\pkg\\sinon\.js/,
and everything works.
PhantomJS 2.1.1 (Windows 8 0.0.0): Executed 27 of 27 SUCCESS (1.017 secs / 0.882 secs)
TOTAL: 27 SUCCESS
=============================== Coverage summary ===============================
Statements : 86.78% ( 197/227 ), 11 ignored
Branches : 75% ( 54/72 ), 3 ignored
Functions : 81.58% ( 31/38 ), 6 ignored
Lines : 56.14% ( 32/57 )
===============================================================================
ah yeah I can run the original version on Windows if I use Git Bash
.
But anyway, this line seems to work for both Command Prompt and Git Bash:
test: /sinon(\\|\/)pkg(\\|\/)sinon\.js/,
Awesome, thanks for figuring that out so quickly. I will update it tomorrow, unless you'd like to submit a PR for it tonight!
yeah I'll do that. We can let Travis test it really works for Linux.
I just cloned
master
andnpm start
works great. But when I trynpm run test
I get a bunch of errors. It looks like allnode_modules/**/*.js
files are getting packaged up or something. For example, all of thenode_modules/sinon/pkg/*.js
files seem to be getting packaged or pulled in in someway.Any ideas what the problem might be?
My OS is Windows 10. Here's a log of my attempt: