search

dvicencio / RiskScorescvd

Cardiovascular Risk Scores
https://dvicencio.github.io/RiskScorescvd/
Other
1 stars 1 forks source link

Making an additional function for SCORE2-Diabetes #5

Closed JauntyJJS closed 3 months ago

JauntyJJS commented 4 months ago

Hi @dvicencio,

Apologies for the late response. Had to recover from an elbow surgery to remove a cyst. I can spend some time to create a separate (if I understand your plans correctly) function for SCORE2-Diabetes. Will open a pull request when it is complete. Please bear with me.

dvicencio commented 4 months ago

Amazing job, Jeremy,

I have accepted the pull request. The function is now in the developing version of the package. I am planning to submit it to CRAN again eventually.

All the best, Dan

JauntyJJS commented 3 months ago

Hi @dvicencio

I understand that you have merged my implementation on the SCORE2-Diabetes. Would you be able to update the documentation for this function ?

image

I have made a mistake and thought that smoker is set to 1 if the patient has a smoking history instead of patient who are currently smoking.

Input integer 0 or 1 to indicate if the patient is a current smoker.

dvicencio commented 3 months ago

Hi Jeremy,

I can do it, but I don't want to mess with your code. I think you could easily do this and submit a pull request with the updated changes again.

Let me know if this works; otherwise I can give it a try.

I am planning to submit the new version to CRAN next week. Would it be okay if I add you as author of the package? You have been really helpful and made substantial contribution to the package.

King regards, Dan

On Fri, May 10, 2024 at 9:30 AM Jeremy Selva @.***> wrote:

Hi @dvicencio https://github.com/dvicencio

I understand that you have merged my implementation on the SCORE2-Diabetes. Would you be able to update the documentation for this function ?

image.png (view on web) https://github.com/dvicencio/RiskScorescvd/assets/9066508/77cd0b88-df81-4312-9c67-29bea55bd906

I have made a mistake and thought that smoker is set to 1 if the patient has a smoking history instead of patient who are currently smoking.

Input integer 0 or 1 to indicate if the patient is a current smoker.

  • 0 stands for patient is not a current smoker (past/former or non-smoker).
  • 1 stands for patient is not a current smoker.

— Reply to this email directly, view it on GitHub https://github.com/dvicencio/RiskScorescvd/issues/5#issuecomment-2104180422, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR5VLRJJWWBOQDDV6F2DMMDZBSARPAVCNFSM6AAAAABGOMHFCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBUGE4DANBSGI . You are receiving this because you were mentioned.Message ID: @.***>

JauntyJJS commented 3 months ago

Hi @dvicencio,

I have added a pull request on the SCORE2-Diabetes documentation.

As for R package authorship, I am fine with that.

The details are as follows,

person(
  given = "Jeremy",
  family = "Selva",
  role = "aut",
  email = "jeremy1189.jjs@gmail.com",
  comment = c(ORCID = "0000-0002-4498-2662")
)