dvidelabs / flatcc

FlatBuffers Compiler and Library in C for C
Apache License 2.0
646 stars 182 forks source link

Enable to build using Clang 15 #254

Closed bjosv closed 1 year ago

bjosv commented 1 year ago

The diagnostics in Clang 15 is stricter and finds some issues.

Some details: https://reviews.llvm.org/D122895

mikkelfj commented 1 year ago

I have seen this main issue before. I generally just fix the main() call. Are there other places that are less trivial to fix?

As to the present_id, I'd like to understood this better. That code wasn't just added for no reason.

bjosv commented 1 year ago

Well, changing the 3 main's was a lot easier..thanks Regarding the present_id, the only thing I can find in the history was that it was used for a fprintf that was removed in https://github.com/dvidelabs/flatcc/commit/0dfe6219d53423f421469dacc5e6adc572d8987d

mikkelfj commented 1 year ago

Good find, seems reasonable to remove it. Ready to merge?

bjosv commented 1 year ago

Yes, I'm happy.