search

dvirtz / vscode-parquet-viewer

A VS Code extension to view Apache Parquet files as JSON
MIT License
28 stars 6 forks source link

Does it run on Windows? #6

Closed pdesmarets closed 4 years ago

pdesmarets commented 5 years ago

Viewer 0.1.3 is installed and enabled. Parquet-tools is in the path. But I still see gibberish. What am I doing wrong?

dvirtz commented 5 years ago

Did you try to use the command?

On Sun, 25 Aug 2019 at 19:25, Pascal Desmarets notifications@github.com wrote:

Viewer 0.1.3 is installed and enabled. Parquet-tools is in the path. But I still see gibberish. What am I doing wrong?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dvirtz/vscode-parquet-viewer/issues/6?email_source=notifications&email_token=AB2ORDPLTQ6JEBUMVBHMFMDQGKXABA5CNFSM4IPJRB4KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HHHXWPQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AB2ORDJDTUZRTSRYCACK7EDQGKXABANCNFSM4IPJRB4A .

dvirtz commented 5 years ago

image

pdesmarets commented 5 years ago

Thanks for your quick response. Yes, I did with same result unfortunately.

image

Both VS Code and parquet-tools (as downloaded from git) are in Windows PATH. What else am I missing? Do parquet-tools need to be built?

dvirtz commented 5 years ago

Can you run parquet-tools from the terminal on that parquet file?

On Mon, 26 Aug 2019 at 09:26, Pascal Desmarets notifications@github.com wrote:

Thanks for your quick response. Yes, I did with same result unfortunately.

[image: image] https://user-images.githubusercontent.com/10139210/63668829-8a613300-c7d8-11e9-9c64-d75458484079.png

Both VS Code and parquet-tools (as downloaded from git) are in Windows PATH. What else am I missing? Do parquet-tools need to be built?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dvirtz/vscode-parquet-viewer/issues/6?email_source=notifications&email_token=AB2ORDLCADP2ZXSQ7GU6OULQGNZP5A5CNFSM4IPJRB4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5DMU3I#issuecomment-524733037, or mute the thread https://github.com/notifications/unsubscribe-auth/AB2ORDIJP6YSSHQUE4SBLZTQGNZP5ANCNFSM4IPJRB4A .

pdesmarets commented 5 years ago

No, I'm getting the error parquet-tools : The term 'parquet-tools' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again. At line:1 char:1

What is your extension looking for? A .jar or something else?

dvirtz commented 5 years ago

It's looking for an executable. I'm using the version installed by homebrew which has a bash script under /usr/local/bin/parquet-tools which contains 

#!/bin/bash
exec java  -jar /usr/local/Cellar/parquet-tools/1.10.0/libexec/parquet-tools-1.10.0.jar "$@"

I guess adding such a script to your path will do the work.

dvirtz commented 5 years ago

Closing. Please comment if that still doesn't work.

pdesmarets commented 5 years ago

I was finally able to create a Windows build of parquet-tools. But I still can't make it work in VSC. I'll just continue with the parquet-tools command line. Thanks

dvirtz commented 5 years ago

In that case I'll keep it open. I'll try to look at it when I'm free.

dvirtz commented 4 years ago

Version 0.1.4 enables putting the path to a parquet-tools jar in the settings. The extension will use this jar in that case. I've tested it on Windows and it seems to work.

pdesmarets commented 4 years ago

Thanks! I'll take a look.