dvirtz / vscode-parquet-viewer

A VS Code extension to view Apache Parquet files as JSON
MIT License
29 stars 6 forks source link

json syntax should be improved #98

Closed eriviere-b closed 9 months ago

eriviere-b commented 1 year ago

When opening a parquet file with the arrow engine, the file is missing the comma between each line an the array symbols. For example I get this:

{"url":"https://www.unrankedsmurfs.com/league-of-legends/buy-skins?skins=PAX%20Jax"}
{"url":"https://www.unrankedsmurfs.com/skins/poppy-skins"}
{"url":"https://www.unrankedsmurfs.com/league-of-legends/buy-skins/Km1KAelE-judgment-kayle-unchained-alistar"}

But I expected that:

[
{"url":"https://www.unrankedsmurfs.com/league-of-legends/buy-skins?skins=PAX%20Jax"},
{"url":"https://www.unrankedsmurfs.com/skins/poppy-skins"},
{"url":"https://www.unrankedsmurfs.com/league-of-legends/buy-skins/Km1KAelE-judgment-kayle-unchained-alistar"}
]
dvirtz commented 1 year ago

This was done to match the output of the official java parquet-tools tool (which was since deprecated). I can add an option to format as an array.

github-actions[bot] commented 11 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 10 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 9 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

dvirtz commented 9 months ago

:tada: This issue has been resolved in version 2.7.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: