search

dvjsharma / Drawn2Shoe

Drawn2Shoe is a user-friendly e-commerce platform. It offers customers the ability to purchase and personalize their shoes. The platform's intuitive interface ensures seamless navigation and usability across a variety of devices.
MIT License
26 stars 44 forks source link

feat: Added Translator #147

Open AsmitaMishra24 opened 2 months ago

AsmitaMishra24 commented 2 months ago

Description

Added Translator.

Issue No.:

Fixes #111

Changes

  1. Added Translator to the navbar.
  2. Adjusted Navbar layout and spacing.
  3. Styled Dropdown Menu for the Translator button.

Screenshot:-

https://github.com/user-attachments/assets/f8b40e6f-d7d5-45ae-ab83-d5095afd4cd1

dvjsharma commented 2 months ago

Hi @AsmitaMishra24, few points:

  1. Functionality looks good.
  2. The position of button is quite redundant, and it also displaces the central logo. This might also break in responsive design. Please look for better placements/design.
  3. (Not a hard requirement since this component might never change) We use tailwind CSS in the entire project, I see you have used plain CSS. Please migrate to tailwind CSS.
AsmitaMishra24 commented 2 months ago

Hi @AsmitaMishra24, few points:

  1. Functionality looks good.
  2. The position of button is quite redundant, and it also displaces the central logo. This might also break in responsive design. Please look for better placements/design.
  3. (Not a hard requirement since this component might never change) We use tailwind CSS in the entire project, I see you have used plain CSS. Please migrate to tailwind CSS.

@dvjsharma, ok....I will make the changes and inform you accordingly