Closed Sid-80 closed 5 months ago
A general advice, you don’t close and open a new PR each time you have to make a change. You can either push more commits to the same branch or amend the previous commit. Helps us to manage things better :)
Oh sorry my bad! Will not be repeated
@dvjsharma Any changes needed ?
@dvjsharma any updates?
https://github.com/dvjsharma/Drawn2Shoe/assets/101277141/b6492fb9-5839-4f37-b9b8-5e335a18f29f
@dvjsharma I have added the logout feature also and stored the login info on redux
Hey @Sid-80, good work on the redux part. But from the last review I still cannot see the changes I asked. Please do the following:
https://github.com/dvjsharma/Drawn2Shoe/assets/101277141/da56c6f1-832d-4ef2-a1f8-2cc02deb7d2a
@dvjsharma Hey! I have made all the requested changes. Please review it. I added redux-persist to keep the redux-store persistent unless the user logout.
@dvjsharma Please review it!
Hey @Sid-80. Continuously pinging us would not guarantee speedy review but will surely guarantee that we are annoyed. Please respect the general waiting period in open source, that is 1 week
CC @ShashankShekhar07
Hello @Sid-80. I still do not see the requested changes implemented. Please do the needful so we can complete the merge.
I made all the changes to server config.
@dvjsharma Please review once! Reverted the changes made in server.
Describe
Added the auth and login state update
Issue
resolves #26