search

dvlden / ultrawideo-v2

Upscale or stretch any video on the web, to make it look great on UltraWide screens.
MIT License
133 stars 20 forks source link

Suggestion: For clarity, rename "Toggle Pause" to "Pause Extension" and "Toggle Modes" to "Switch Mode" #77

Closed WinkelCode closed 2 years ago

WinkelCode commented 2 years ago

Re: #17 #20

I usually expect a toggle to be a binary switch, right now both keybindings "Toggle Pause" and "Toggle Modes" are not binary switches, and in particular with the "Toggle Pause" keybind, I initially thought its behavior was a bug due to that description.

My proposal is to rename "Toggle Pause" to "Pause Extension", this would make it clearer that it's a one-way operation and also explain why the keybind no longer works once triggered (the extension is, well, paused).

I also propose renaming "Toggle Modes" to "Switch Mode", while "toggle" isn't too out of place here, I believe using "switch" would be more fitting as it "switches through" different modes. "Rotate Mode" would also work.

Edit: Changed "Modes" to "Mode", since it's not a group of modes that is being selected, but a single mode.

dvlden commented 2 years ago

Sure thing. I think I did it exactly as you described. Let me know if that's what you meant.

Thanks for the suggestion!

WinkelCode commented 2 years ago

Thanks for implementing my suggestion, everything looks great on my end 👍